Skip to content

ENH: Adding docstub #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2025
Merged

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented May 22, 2025

It's ready for the public usage, so time to list on the website

cc @stefanv @lagru

Copy link

netlify bot commented May 22, 2025

Deploy Preview for tools-scientific-python-org ready!

Name Link
🔨 Latest commit e105bde
🔍 Latest deploy log https://app.netlify.com/projects/tools-scientific-python-org/deploys/682e744a2b834a0008edc1ff
😎 Deploy Preview https://deploy-preview-71--tools-scientific-python-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99
Accessibility: 96
Best Practices: 100
SEO: 100
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@stefanv
Copy link
Member

stefanv commented May 22, 2025

@lagru Happy to put this up, if you think you're ready for some more eyes on the project!

@lagru
Copy link
Member

lagru commented May 23, 2025

Happy too! But could we wait until I've completed the minimal documentation (scientific-python/docstub#24)? I'd like to give first users at least a chance to grok the concepts involved. 😅

After that I'll release v0.3 and approve this. 😊

@bsipocz bsipocz requested a review from lagru May 23, 2025 16:53
@bsipocz
Copy link
Member Author

bsipocz commented May 23, 2025

Sounds like a plan, thanks!

@lagru
Copy link
Member

lagru commented May 24, 2025

Fyi, preparing docstub 0.3.0 in scientific-python/docstub#51.

Copy link
Member

@lagru lagru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I released version 0.3.0.post0. After some annoying shenanigans, I had to make a post release. It seems that my deployment workflow didn't really agree with me tagging the same commit with 0.3.0rc0 and 0.3.0. I think while pushing the final release, setuptools still tried to use the 0.3.0rc0 instead of 0.3.0. Couldn't reproduce that locally.

So note to myself, always make sure that release tags point to different commits. Even if that means unnecessarily pushing something. 😅

@lagru lagru merged commit f02ec75 into scientific-python:main May 25, 2025
5 checks passed
@bsipocz bsipocz deleted the ENH_adding_docstub branch May 25, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants